Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to pydantic v2 (->postponed) #142

Open
dalito opened this issue Aug 8, 2023 · 1 comment
Open

Upgrade to pydantic v2 (->postponed) #142

dalito opened this issue Aug 8, 2023 · 1 comment
Labels
housekeeping Clean-up or maintenance tasks like updates etc.

Comments

@dalito
Copy link
Member

dalito commented Aug 8, 2023

I did a test-upgrade to pydantic v2 (using pydantic 2.1.1 and voc4cat-tool 0.6.0). The upgrade breaks a lot of the validation code. The tool bump-pydantic that should help with the upgrading process is of almost no help; it made only few small changes. Thus, upgrading currently requires going through a long list of changes with often unclear instructions how to adapt the code.

The upgrade may be tried again at a later point. Now we should stay with version 1.x. The speed benefits that v2 promises are not relevant for this project.
@dalito dalito added the housekeeping Clean-up or maintenance tasks like updates etc. label Aug 8, 2023
@dalito
Copy link
Member Author

dalito commented Sep 20, 2023

Example for a pydantic upgrade which required quite a lot of changes. This confirms my assessment from above.

@dalito dalito mentioned this issue Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
housekeeping Clean-up or maintenance tasks like updates etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dalito