New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustment waterlevel (zs) to bed level (zb) #178

Open

bartvanwesten opened this issue Dec 4, 2023 · 1 comment

Collaborator

bartvanwesten commented Dec 4, 2023

Create a general function (in utils.py) to adjust zs to zb and call everytime zb is adjusted (avalanching, bed_update, wet_bed_reset, ...?)

Collaborator

Sierd commented Aug 18, 2024

@bartvanwesten is this properly addressed by these lines? Or do you have something else in mind?

aeolis-python/aeolis/avalanching.py

Lines 187 to 190 in ac0cc34

    
           # Ensure water level is up-to-date with bed level 
        
           s['zs'] = s['SWL'].copy() 
        
           ix = (s['zb'] > s['zs']) 
        
           s['zs'][ix] = s['zb'][ix]

Sierd mentioned this issue

Change in the manner 'zs' is being computed for 1D cases: Intentional or bug? #223

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment