Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect creation / removal of notes and sub-folders when in Experimental Note Tree Mode #3072

Open
HendersonSoftworks opened this issue Aug 5, 2024 · 5 comments

Comments

@HendersonSoftworks
Copy link

Expected behavior

Clicking directory tree node changes application directory context to that directory tree node.

Application should know commands are being directed towards sub-folders if they are selected.

Actual behavior

App directory context only changes when clicking on a note. Nothing happens when clicking on sub-folders, so commands effect the last selected note.

Steps to reproduce

Deletion issue:

  1. Enable experimental note tree mode
  2. Select directory node (notice preview panel still has contents of last node)
  3. Press Del key, last note will be deleted

Note creation issue:

  1. Enable experimental note tree mode
  2. Create new sub-folder tree node (notice preview panel still has contents of last node)
  3. Press CTRL+N, note will be created in the last selected directory, not the new directory
Expand

Absolutely love this application! It's been a game-changer for me, so thanks for all your hard work!

I'm a tree-mode user, so am aware that my issue is due to this experimental feature. The application doesn't seem to change which directory / tree node is currently selected unless you click on a note. This makes it easy to delete notes, when you really wanted to delete a directory. Similarly, if you want to create a new note, clicking on the sub-directory doesn't change the directory where the application is currently set, meaning that the newly created note is some other directory you were looking at.

@pbek
Copy link
Owner

pbek commented Aug 5, 2024

Looks like you are talking about the work in progress feature #790, right?
If yes, then it would be the best to deposit your request there... 😉

Copy link

github-actions bot commented Sep 5, 2024

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the Stale No activity for a while label Sep 5, 2024
@pbek
Copy link
Owner

pbek commented Sep 14, 2024

Hm, it's not happening all the time that the note is created in the wrong folder. 🤔
But there was another report at #3108.

pbek added a commit that referenced this issue Sep 14, 2024
@pbek
Copy link
Owner

pbek commented Sep 14, 2024

Maybe this will help, need to test more.

24.9.6

  • The accidental note selection when selecting a note subfolder in the experimental
    note tree mode was fixed
    (for #3072)
    • This was also causing the wrong subfolder to be used when a new note was created

@pbek pbek mentioned this issue Sep 14, 2024
@pbek
Copy link
Owner

pbek commented Sep 14, 2024

There now is a new release, could you please test it and report if it works for you?

@pbek pbek removed the Stale No activity for a while label Sep 14, 2024
pbek added a commit that referenced this issue Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants