Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request angular-material so they will publish directly to Meteor #1

Open
Urigo opened this issue Apr 16, 2015 · 5 comments
Open

Comments

@Urigo
Copy link

Urigo commented Apr 16, 2015

Very nice work!

It will be best if you would pull request the angular-material library to help them publish their own version to Meteor.

They use Gulp so here is a guide on how to do that:
https://github.com/MeteorPackaging/grunt-gulp-meteor

Then until they will merge your pull request you could publish from the fork with this gulp task.

Also, I would change the namespacing of the publisher to make it official, like

angularjs:angular-material

(someone already took the 'angular' namespace...)

Send me your Meteor user name and I will add you to the angularjs Meteor organization so you can publish straight to there..

For more information:
https://github.com/MeteorPackaging
MeteorCommunity/discussions#14
https://www.youtube.com/watch?v=g-idz8UPtDM
https://www.youtube.com/watch?v=mIxZnOtWUUY

@dohomi
Copy link
Member

dohomi commented Apr 17, 2015

Thanks @Urigo

I forked the angular material project, but actually they don't have the compiled sources inside of their repo. Everything is compiled inside of https://github.com/angular/bower-material but that repo I guess gets autocompiled. Will see when I get into it.

Cheers

@Urigo
Copy link
Author

Urigo commented Apr 17, 2015

Yes it's like AngularJS.. maybe you can still pull request their gulp tasks and continue publishing here or maybe just create an issue for them with all the information

@Urigo
Copy link
Author

Urigo commented Apr 24, 2015

@dohomi I've created the 'angular' organization and add you in so you can now publish the material library there.

@dohomi
Copy link
Member

dohomi commented Apr 27, 2015

Hi Urigo,

I checked out the angular organization and its projects. Currently they all point to the github version of the bower project of angular. It looks that you are still maintaining the files? Would like to publish my project but I need to wait that you link urigo:angular to the angular:angular project as well, otherwise angular is getting loaded twice in my app.

How about angular:ui-calendar? I wrote a wrapper for planet training, shall I publish it there as well?

Best Regards,

Dominic

On 25.04.2015, at 03:37, Uri Goldshtein [email protected] wrote:

@dohomi https://github.com/dohomi I've created the 'angular' organization and add you in so you can now publish the material library there.


Reply to this email directly or view it on GitHub #1 (comment).

@Urigo
Copy link
Author

Urigo commented Apr 27, 2015

Yes I get it.
I'm updating it right now and will release a new version this week.
You can update the code and wait with the release or release a new version that will only support our new version (so we won't have to wait for each other).
I also need to update other libraries that depend on angularjs:angular but let not wait and just go ahead, otherwise it might not end...

about angular:ui-calendar yes that will be great, just publish it under angularui:ui-calendar because it's an angular-ui project and not angular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants