Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --amend #27

Open
FRidh opened this issue Oct 26, 2023 · 2 comments
Open

Support --amend #27

FRidh opened this issue Oct 26, 2023 · 2 comments

Comments

@FRidh
Copy link

FRidh commented Oct 26, 2023

There are quite some actions out there that create commits. Unfortunately, they are not signed. Adding support for --amend should, if I am correct, make it possible to sign commits created by other actions.

Note I do not know whether ghcommit supports that.

@npanuhin
Copy link

I also really need the ability to amend a commit (other/custom parameters for the git commit would also be nice)

@joemiller
Copy link
Member

This will depend on whether or not the createCommitOnBranch graphql api supports amending existing commits. From a glance at the docs I do not think that's the case. https://docs.github.com/en/graphql/reference/mutations#createcommitonbranch

I also searched that page for "amend" and came up with nothing :|

If anyone finds a method for amending I'd be happy to take a look at implementing it in https://github.com/planetscale/ghcommit

This may require a feature request to github's graphql api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants