OpenID login error: NoMethodError: undefined method `index' for server_url (which is nil)

[sentry-io]

Sentry Issue: MAPKNITTER-5B

NoMethodError: undefined method `index' for nil:NilClass
  openid/store/filesystem.rb:29:in `get_association_filename'
    unless server_url.index('://')
  openid/store/filesystem.rb:82:in `get_association'
    filename = get_association_filename(server_url, handle)
  openid/consumer/idres.rb:209:in `check_signature'
    assoc = @store.get_association(server_url, fetch('assoc_handle'))
  openid/consumer/idres.rb:74:in `id_res'
    check_signature
  openid/consumer/idres.rb:59:in `initialize'
    id_res
...
(69 additional frame(s) were not displayed)

[jywarren]

I just saw this while trying to log in using OAuth, as "warren" --

Why is server_url nil? Are we seeing an issue with openid filesystem storage?

[icarito]

Hmmm is it an OAuth or OpenID issue? Are they coupled in any way?
We tested this, will investigate.

[icarito]

Hmm I couldn't reproduce at first from here:

• I logged in to Publiclab.Org with Github OAuth,
• I logged into Mapnitter using OpenID from Publiclab.Org (regular user/password).
  But I did get a 500 error when trying to log into Mapknitter with Github OAuth.

[icarito]

I just saw this while trying to log in using OAuth, as "warren" --

Why is server_url nil? Are we seeing an issue with openid filesystem storage?

We host Mapknitter in Google Appengine since a long time, and we hadn't previously noticed this. There's been no change in this, I'll dig into the Google infrastructure for clues.

[icarito]

I see errors for this as far back as February in Sentry, I guess it's been there all along since we moved to Google Appengine.

[sentry-io]

This is the issue I managed to reproduce. But I couldn't reproduce an OpenID issue.

Sentry issue: MAPKNITTER-4G

[jywarren]

OK great, i moved the OAuth error to #1516

[jywarren]

When logging into PL.org fresh (in incognito) then using OpenID from MapKnitter, I don't see this error.

[jywarren]

This has happened only 4 times. I'll try logging out of my current session and logging back in.

[jywarren]

Strange, i didn't even have to log out. The second time i tried to log in from MapKnitter via OpenID, it worked. I'll close this with the recommended fix "try again" -- dissatisfying but... pretty rare!