Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-button]: target="_blank" for MenuButton / MenuLink #949

Open
Emina198 opened this issue Jul 27, 2022 · 0 comments
Open

[menu-button]: target="_blank" for MenuButton / MenuLink #949

Emina198 opened this issue Jul 27, 2022 · 0 comments

Comments

@Emina198
Copy link

🚀 Feature request

Either or both the MenuButton and MenuLink should have an option to propagate a target for the link.

Current Behaviour

At the moment we can attach the target="_blank" to the MenuLink directly as a prop, but it doesn't work.

Desired Behaviour

Attaching a target prop should work as described.

Who does this impact? Who is this for?

It impacts everyone who wants to use the link and expects it to have link behaviour.

Describe alternatives you've considered

A workaround is to wrap the MenuItem in both a and an element, like so:

<Link
    href={{pathname: ROUTE}}
    passHref
    >
    <a target="_blank">
        <MenuItem>Link</MenuItem>
    </a>
</Link>
@Emina198 Emina198 changed the title target="_blank" for MenuButton / MenuLink [menu-button]: target="_blank" for MenuButton / MenuLink Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant