Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce stack pressure #867

Open
neurolabusc opened this issue Sep 30, 2024 · 0 comments
Open

Reduce stack pressure #867

neurolabusc opened this issue Sep 30, 2024 · 0 comments

Comments

@neurolabusc
Copy link
Collaborator

As @hanayik noted when compiling dcm2niix for web assembly, dcm2niix makes huge demands on stack size, requiring special directives for some operating systems. The next few commits to the development branch attempt to reduce this. These changes are made as three commits to aid understanding any consequences:

  1. v1.0.20240929 will use heap instead of stack memory, but will not reduce the memory allocations. This only slightly reduces the peak memory usage.
  2. v1.0.20240930 adjusts the size of memory allocations based on the size of dataset being converted. This somewhat reduces peak memory demands for the worst case scenarios (e.g. Philips enhanced DICOM with multiple echoes and timepoints).
  3. v1.0.20241001 removes stack size changes in the makefile and CMakeLists.txt.

@yhuang43 @jonclayden @ningfei @hanayik will want to test their derived code bases to check for unintended consequences.

neurolabusc added a commit that referenced this issue Sep 30, 2024
neurolabusc added a commit that referenced this issue Sep 30, 2024
neurolabusc added a commit that referenced this issue Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant