Improve unnamed_socket diagnostics #3912
Labels
A-shims
Area: This affects the external function shims
C-enhancement
Category: a PR with an enhancement or an issue tracking an accepted enhancement
E-good-first-issue
A good way to start contributing, mentoring is available
Here are some improvements that could be done:
read/write
is shared betweenpipe2
andsocketpair
, the diagnostic forthrow_unsup_format
shouldn't only mentionsocketpair
:miri/src/shims/unix/unnamed_socket.rs
Line 168 in 00bafbe
miri/src/shims/unix/unnamed_socket.rs
Line 239 in 00bafbe
O_NONBLOCK
flag is used onpipe2
,unsupported_error
will be thrown. Since we support non-blockingpipe2
, we might want to allow this flag.The text was updated successfully, but these errors were encountered: