Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unnamed_socket diagnostics #3912

Open
tiif opened this issue Sep 24, 2024 · 0 comments
Open

Improve unnamed_socket diagnostics #3912

tiif opened this issue Sep 24, 2024 · 0 comments
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement E-good-first-issue A good way to start contributing, mentoring is available

Comments

@tiif
Copy link
Contributor

tiif commented Sep 24, 2024

Here are some improvements that could be done:

  1. Since unnamed_socket read/write is shared between pipe2 and socketpair, the diagnostic for throw_unsup_format shouldn't only mention socketpair:
  1. Currently, if O_NONBLOCK flag is used on pipe2, unsupported_error will be thrown. Since we support non-blocking pipe2, we might want to allow this flag.
@oli-obk oli-obk added the E-good-first-issue A good way to start contributing, mentoring is available label Sep 24, 2024
@RalfJung RalfJung added C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement A-shims Area: This affects the external function shims labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement E-good-first-issue A good way to start contributing, mentoring is available
Projects
None yet
Development

No branches or pull requests

3 participants