Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrupts/registers do not match the H7 datasheet #11

Open
yorickdewid opened this issue Mar 2, 2022 · 4 comments
Open

Interrupts/registers do not match the H7 datasheet #11

yorickdewid opened this issue Mar 2, 2022 · 4 comments

Comments

@yorickdewid
Copy link
Contributor

The block reference manual (RM0433) lists different interrupts and registers than the current driver expects.

Found so far:

  • RM044 section 56.5.16 FDCAN_IE is different than what src/interrupt.rs lists.
  • RX FIFO (RXFnC.FnWM) watermark is never set which means it will default to 0. Any RAM index greater than 0 will be reported as 'overrun'.
@richardeoin
Copy link
Member

These are differences in the STM32H7 / STM32MP1 FDCAN controller that aren't captured by the feature gates. Thanks for listing these two - have you found any more?

@yorickdewid
Copy link
Contributor Author

So for not, but I'm sure there are more.

@richardeoin
Copy link
Member

RM044 section 56.5.16 FDCAN_IE is different than what src/interrupt.rs lists.

Fixed by #14

RX FIFO (RXFnC.FnWM) watermark is never set which means it will default to 0

I think that should be fixed in the H7 HAL implementation, specifically here

richardeoin added a commit to richardeoin/stm32h7xx-hal that referenced this issue Mar 14, 2022
richardeoin added a commit to richardeoin/stm32h7xx-hal that referenced this issue Mar 18, 2022
@David-OConnor
Copy link

David-OConnor commented May 14, 2023

So fun fact should anyone come across this, but on G4 you need to reverse the interrupt lines in both the NVIC name and when enabling the line; this error goes all the way back to ST's reference manual. (Works as expected on H7)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants