Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transmit_preserve pending data parameter as u8 slice? #53

Open
projectgus opened this issue Sep 6, 2024 · 0 comments
Open

transmit_preserve pending data parameter as u8 slice? #53

projectgus opened this issue Sep 6, 2024 · 0 comments

Comments

@projectgus
Copy link

(Sorry for the sudden flurry of posts)

I was wondering if a PR to change the u32 slice in the transmit_preserve callback to a u8 would be acceptable? i.e. PTX: FnMut(Mailbox, TxFrameHeader, &[u32]) -> P, to PTX: FnMut(Mailbox, TxFrameHeader, &[u8]) -> P,

It would be a breaking change, but it would bring the API in line with the other data parameters which are all &[u8]s.
@projectgus projectgus changed the title transmit_preserve pending argument as u8 slice? transmit_preserve pending data parameter as u8 slice? Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@projectgus