New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on consistent strategy for enabling peripherals #154

Open

hannobraun opened this issue Nov 3, 2021 · 0 comments

Labels

enhancement help wanted

Contributor

hannobraun commented Nov 3, 2021

@burrbull wrote this in #152 (comment):

I would say you need to decide what API you want.
Now all peripheral init functions are different.
Some take &mut APBx, other &mut Rcc. Some take nothing and make peripheral enable in unsafe, other in interrupt::free mode.

My reply in #152 (comment):

Not sure, to be honest. It's been a while since I actually used this HAL, or worked on the design of a STM32 HAL, or really thought about the design of STM32 HALs.

It would be better if it was consistent, of course, but I don't know which of the options is best. Suggestions welcome!

hannobraun added enhancement help wanted labels

hannobraun mentioned this issue

rcc enable #152

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment