Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: mirror primitive applies max target lag time incorrectly #16877

Open
maxenglander opened this issue Oct 2, 2024 · 0 comments · May be fixed by #16879
Open

Bug Report: mirror primitive applies max target lag time incorrectly #16877

maxenglander opened this issue Oct 2, 2024 · 0 comments · May be fixed by #16879
Labels
Component: Query Serving Type: Bug

Comments

@maxenglander
Copy link
Collaborator

maxenglander commented Oct 2, 2024 •
edited
Loading

Overview of the Issue

The VTGate mirror primitive was written with the intention of having the mirror target be canceled if it continues executing for a short period of time after the source primitive finishes executing. However as it is currently written the mirror target will be canceled if it executes for more than 100ms.

vitess/go/vt/vtgate/engine/mirror.go

Line 78 in 978c59d

mirrorCtx, mirrorCtxCancel := context.WithTimeout(ctx, maxMirrorTargetLag)

@maxenglander maxenglander added Type: Bug Needs Triage This issue needs to be correctly labelled and triaged Component: Query Serving and removed Needs Triage This issue needs to be correctly labelled and triaged labels Oct 2, 2024
@maxenglander maxenglander linked a pull request Oct 2, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
1 participant
@maxenglander