Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: If VTOrc is configured to convert tablets with errant gtids to drained type, it soon forgets them #16887

Open
GuptaManan100 opened this issue Oct 3, 2024 · 0 comments · May be fixed by #16888
Labels
Component: VTorc Vitess Orchestrator integration Type: Bug

Comments

@GuptaManan100
Copy link
Member

Overview of the Issue

It was noticed that if VTOrc is running with the --change-tablets-with-errant-gtid-to-drained flag, then after it converts a tablet that has an errant GTID to a drained type, it forgets them! This leads to the metric of ErrantGTIDTabletCount to be incorrect, since VTOrc removed the tablet that had the errant GTID from its list of tablets! That metric then always reports a value of 0 which is incorrect since we have errant GTIDs that need to be looked at by the user.

Reproduction Steps

  1. Run VTOrc with --change-tablets-with-errant-gtid-to-drained flag
  2. Introduce an errant GTID on a replica.
  3. Monitor the ErrantGTIDTabletCount gauge and see that it goes to 0 even without us fixing any errant GTID.

Binary Version

main

Operating System and Environment details

-

Log Fragments

No response

@GuptaManan100 GuptaManan100 added Type: Bug Component: VTorc Vitess Orchestrator integration labels Oct 3, 2024
@GuptaManan100 GuptaManan100 linked a pull request Oct 3, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTorc Vitess Orchestrator integration Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant