Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module forces v5 repos when running on a non windows OS #852

Open
Ph0B1uS opened this issue Nov 25, 2022 · 5 comments
Open

Module forces v5 repos when running on a non windows OS #852

Ph0B1uS opened this issue Nov 25, 2022 · 5 comments

Comments

@Ph0B1uS
Copy link

Ph0B1uS commented Nov 25, 2022

if downcase($facts['kernel']) == 'windows' {
$zabbix_version = '4.4.5'
} else {
$zabbix_version = '5.0'
}

This is the offending line which makes it impossible to install any version above 5.X as the repo is managed by the module and only installs v5 rather than adapting to zabbix_version

@Ph0B1uS Ph0B1uS changed the title Module defaults to v5 repos when running on a non windows OS Module forces v5 repos when running on a non windows OS Nov 25, 2022
@root-expert
Copy link
Member

Hello @Ph0B1uS, if you override zabbix_version it will install the specified version, the code above is just the default value.
Can you post some puppet code to understand better your problem?

@ekohl
Copy link
Member

ekohl commented Nov 7, 2023

As @root-expert said, those are just the defaults and you can choose another version. Closing due to inactivity, but feel free to reopen if it's still an issue.

@ekohl ekohl closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
@Ph0B1uS
Copy link
Author

Ph0B1uS commented Nov 7, 2023

It will install the specified version of the zabbix-package but it doesn't seem to affect what repo is set up.
It's fine to specify v 6.4.2 but since the repo installed is 5.x by default then all that will do is result in a failed puppet run since there is no zabbix v 6.4.2 in the 5.x repo.

@ekohl
Copy link
Member

ekohl commented Nov 7, 2023

Perhaps you can give some examples of how you're using the module.

@ekohl ekohl reopened this Nov 7, 2023
@Valantin
Copy link
Contributor

@Ph0B1uS can you add more detailed information?
Like your OS version and a manifest example of how you use this module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants