-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oEmbed field type returns url, not embed #106
Comments
fix: oembed field type returns embed instead of URL entered to the field
I have the opposite desire and would really prefer the url (or src of the iframe). I think this was the previous behaviour. I understand that the full iframe code may be needed by some, but if building say a react application or similar you'd probably want to handle the iframe yourself. Some ACF fields have options to what they return - oEmbed doesn't, but perhaps this could be included in the graphQL options in ACF. Is there an existing way to get the url returned without parsing the returned html (which seems more risky). |
@amcc would you mind opening that as a new issue so it doesn't get lost? I think we can come up with a way to satisfy both options. Like a field argument that lets you choose the return format when querying the field? Something like: |
new issue to track here: #150 |
Description
As a developer querying for a field of the oEmbed type, I expect to get the embed HTML returned so that I can use it in my client application.
Instead, the field is returning the url that was input.
Steps to reproduce
I would expect an HTML payload that could be used by the client application to render the embed:
With the URL being returned, this means the client application is responsible for making the oAuth requests to get the oAuth response and determine the proper markup to apply. WordPress already does this, so we should let the server handle this and return an already cached/formatted embed.
PHP or JSON export of the ACF Field Group(s)
No response
Additional context
No response
WPGraphQL Version
1.17.0
WPGraphQL For ACF Version
latest beta
ACF (Advanced Custom Fields) Version. Free or Pro?
latest pro
WordPress Version
6.3
PHP Version
8.1
Additional enviornment details
No response
Please confirm that you have searched existing issues in the repo.
Please confirm that you have disabled ALL plugins except for WPGraphQL, WPGraphQL For ACF, ACF, etc.
The text was updated successfully, but these errors were encountered: