New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use more stable var, std algo #386

Open

dcherian opened this issue Aug 14, 2024 · 0 comments

Collaborator

dcherian commented Aug 14, 2024 •

edited

Loading

https://www.johndcook.com/blog/2008/09/26/comparing-three-methods-of-computing-standard-deviation/
https://www.johndcook.com/blog/2008/09/28/theoretical-explanation-for-numerical-results/

will require upstream fixes to npg too.

This should let us delete this SKIPPED_FUNCS bit:

flox/tests/strategies.py

Lines 35 to 39 in 4dbadae

    
           SKIPPED_FUNCS = ["var", "std", "nanvar", "nanstd"] 
        
           func_st = st.sampled_from( 
        
               [f for f in ALL_FUNCS if f not in NON_NUMPY_FUNCS and f not in SKIPPED_FUNCS] 
        
           )

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment