-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "Simple Taproot Channels" BOLT proposal #2868
base: store-partial-signatures
Are you sure you want to change the base?
Conversation
0082aea
to
51ec562
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2868 +/- ##
==========================================
+ Coverage 85.92% 86.38% +0.46%
==========================================
Files 219 220 +1
Lines 18488 19477 +989
Branches 794 814 +20
==========================================
+ Hits 15886 16826 +940
- Misses 2602 2651 +49
|
51ec562
to
cdefa9a
Compare
786cfa1
to
f9fe228
Compare
f9fe228
to
7480cee
Compare
37553dc
to
1966835
Compare
46ef2b7
to
155b8dc
Compare
1966835
to
2015ced
Compare
452c0e0
to
16e75b0
Compare
2015ced
to
c259402
Compare
57310de
to
0ac5a45
Compare
c259402
to
537d134
Compare
0ac5a45
to
af1d5c7
Compare
537d134
to
22e6a8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far. I focused this preliminary review on splicing to identifiy any potential nonce reuse issues early.
I found one potential issue if we allow tx_abort
after we send commit_sig
.
I also think RBF of splices will need to be done carefully to avoid nonce resuse. I think we will need to include the RBF attempt count when generating nonces. I'll review again once you've rebased on the latest splice branch that includes splice RBF.
eclair-core/src/main/scala/fr/acinq/eclair/channel/fund/InteractiveTxBuilder.scala
Show resolved
Hide resolved
af1d5c7
to
5e9706a
Compare
cb1a0ff
to
dc59336
Compare
This commit implements: - feature bits for simple taproot channels - TLV extensions for funding/closing wire messages - modifications to how we handle channel funding and mutual closing - changes to the commitment structures It does not cover dual-funding and splices, which are not part of the original extension proposal.
The current "simple taproot channels" proposal is not compatible with splices. Supporting splices means supporting multiple commitment transactions that are valid at the same time, with the same commitment index but with different funding transactions. We need to extend the taproot proposal to include a list of musig2 nonces (one for each active commitment transaction). Similar to how commitment points are handled, `firstRemoteNonce` and `secondRemoteNonce` fields have been added to `SpliceInit` and `SpliceAck`, encoded as a list of nonces (instead of 2 expicit nonces) We also need a for the new commit tx that is being built, here it has been added to `SpliceInit` and `SpliceAck`. The funding tx that is being built during the interactive session needs to spend the current funding tx. For this, we re-use the scheme that we developped for our custome "swaproot" musig swap-ins: we add musig2 nonces to the `TxComplete` message, one nonce for each input that requires one, ordered by serial id. The life-cycle of these nonces is tied to the life-cycle of the interactive session which is never persisted (nonces here do not have to be deterministic).
…d unsafe) anchor output format
… nonce generation
5e9706a
to
1926d8a
Compare
dc59336
to
799c1da
Compare
This PR implements lightning/bolts#995 which introduces a new channel format where funding transactions send to an aggregated musig2 public key instead of a 2-of-2 multisig address:
Basic interop testing (opening/closing channels, sending/receiving payments) pass with lnd v0.18
The trickiest part of this PR is the update to the splicing protocol: splicing means that there can be multiple commitment transactions that are active at the same time, and signatures must be exchanged for all of them. With the new musig2-based funding transaction scheme, this means generating and exchanging musig2 nonces in advance, which requires modifications to the interactive tx and splicing protocols that are not (yet) covered by the BOLT proposal.
This is still a WIP, we also need to add support for simple taproot channels to https://github.com/ACINQ/lightning-kmp.
Based on #2896