Retrieve feerates everytime we reconnect to electrum #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And catch errors, so if current Electrum server has a problem we can retry with a new one.
|
Since we want to retrieve onchain fee rate each time we connect to an electrum server, and that some may fail to return a valid response, another approach would be to add retrieving fee rates to the handshake we perform when we establish a new connection, see #490 ? |
|
Isn't this obsolete after #649 where we let our peer advertise the feerates they accept through the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, we were only retrieving the feerates once during the lifetime of the app. If we happen to connect to an unhealthy Electrum server (connection succeeds, but then we get
ServerError(request=EstimateFees(confirmations=18), error=JsonRPCError(code=-102, message=server busy - request timed out))), then the app will fail to start and actually crash.This change is more subtle than it may look. Not only do we catch and ignore errors, but we also retrieve feerates at each reconnection. The goal is that in the scenario above we would try another electrum server and get back on our feet.