Make Peer.trustedSwapInTxs a callback
#516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows adding txids without restarting the Peer and facilitates testing.
t-bast
approved these changes
Aug 18, 2023
pm47
added a commit
that referenced
this pull request
Aug 18, 2023
Instead of explicitly providing txids, we can look at local channel data to extract mutual close txids, because either the tx is unconfirmed and the channel data will still be in `Closing` state, otherwise the tx is confirmed and the utxo can be used immediately anyway. This is an alternative to #516.
pm47
added a commit
that referenced
this pull request
Aug 18, 2023
Instead of explicitly providing txids, we can look at local channel data to extract mutual close txids, because either the tx is unconfirmed and the channel data will still be in `Closing` state, otherwise the tx is confirmed and the utxo can be used immediately anyway. This is an alternative to #516.
|
Superseded by #517. |
pm47
added a commit
that referenced
this pull request
Aug 18, 2023
Instead of explicitly providing txids, we can look at local channel data to extract mutual close txids, because either the tx is unconfirmed and the channel data will still be in `Closing` state, otherwise the tx is confirmed and the utxo can be used immediately anyway. This is an alternative to #516.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows adding txids without restarting the Peer (useful for iOS channel migration/consolidation) and facilitates testing.