Update for ElectrumClient rework
#418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- connection state is derived from ElectrumConnectionStatus - blockheight is needed to get a tx confirmation state - the socket builder is moved to the `connect` method Several methods have been commented in the Android/iOS UI for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ElectrumClienthas been reworked in ACINQ/lightning-kmp#512, fixing several issues and generally improving the reliability of the client. The impact on Phoenix codebase is small.@robbiehanson A notable addition is the timeout to
connect(default is 15s, and for now we use that value).Also note that the
connectionStateflow has been removed, the client now exposes a flow ofElectrumConnectionStatus- that can be easily converted to a more genericConnectionobject.This has been successfully tested on Android and iOS, and can be merged as-is. However the nature of the issues and the fixes provided by this rework means that we'll have to keep an eye on this.