Upgrade to lightning-kmp 1.8.2 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ACINQ/lightning-kmp#709 and ACINQ/lightning-kmp#710, the mining fee for liquidity events is split between local and purchase fee. However, we don't directly store the split fees, for backward compatibility reasons. Thus, to get the local fee from the database, we must compute it back.
pm47
reviewed
Oct 10, 2024
| @@ -244,6 +244,7 @@ class Phoenixd : CliktCommand() { | |||
| maxAbsoluteFee = liquidityOptions.maxMiningFee, | |||
| maxRelativeFeeBasisPoints = liquidityOptions.maxRelativeFeeBasisPoints, | |||
| skipAbsoluteFeeCheck = false, | |||
| considerOnlyMiningFeeForAbsoluteFeeCheck = true, | |||
There was a problem hiding this comment.
This preserves the same behavior as before lightning-kmp 1.8.
pm47
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades phoenixd to use lightning-kmp v1.8.2. The main change with v1.8.0 is that the mining fee incurred by a liquidity purchase event triggered by a swap-in must be split between the two payments (lest it's counted twice).
There are side effects on other splice operations, which means we have a new
localMiningFeesfield to store in the database.To store this data in a backward compatible way, we do not store the local fee directly. Instead, we store the full mining fee (as before), and we retrieve the local fee by subtracting the purchase fee from the full fee.