Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare implementation for DPT (Depth of Water) messages #132

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

trkohler
Copy link
Contributor

@trkohler trkohler commented Aug 25, 2024

connect: #54

@elpiel
Copy link
Member

elpiel commented Aug 26, 2024

I see you made a typo, this is why you get a name conflict.
The type of the sentence is DPT, instead of DBT. If you use DPT there will be no conflict.

Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/parse.rs Outdated Show resolved Hide resolved
@trkohler trkohler changed the title Prepare implementation for DBT (Depth of Water) messages Prepare implementation for DPT (Depth of Water) messages Aug 26, 2024
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
@trkohler
Copy link
Contributor Author

tests currently not passing because I need to clarify how to handle those cases: $SDDPT,2.4,,*53 and $SDDPT,15.2,0.5,*6C (with trailing commas)

src/sentences/dpt.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.98%. Comparing base (5675768) to head (604bfa1).

Files with missing lines Patch % Lines
src/sentences/dpt.rs 83.33% 5 Missing ⚠️
src/parser.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   77.93%   77.98%   +0.05%     
==========================================
  Files          37       38       +1     
  Lines        1405     1440      +35     
==========================================
+ Hits         1095     1123      +28     
- Misses        310      317       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trkohler trkohler marked this pull request as ready for review August 31, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants