Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format string conversion specifiers #6192

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

imaami
Copy link

@imaami imaami commented Jul 10, 2020

Signed-off-by: Juuso Alasuutari [email protected]

@imaami
Copy link
Author

imaami commented Jul 10, 2020

@AlexeyAB This fixes all the incorrect printf format string conversion specifiers I could find. At least one of them in src/http_stream.cpp may cause a garbage value to be printed in the HTTP header's Content-Length unless it's fixed, because it will read 8 bytes from the stack even though the integer at that location is 4 bytes long.

@cenit cenit requested a review from AlexeyAB April 17, 2021 21:51
@cenit cenit merged commit 68100fb into AlexeyAB:master Aug 26, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants