Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realsense #6407

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Add realsense #6407

wants to merge 21 commits into from

Conversation

juhong-rdv
Copy link

Realsense2 camera (RGB) can be used.

Copy link
Owner

@AlexeyAB AlexeyAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juhong-rdv Hi,

Is it better to integrate Intel-Realsense RGBD to the https://github.com/AlexeyAB/darknet/blob/master/src/yolo_console_dll.cpp instead of Darknet, as it is done for ZED-Camera, so it can show Distance to the objects too?

Comment on lines +594 to +608
#ifdef REALSENSE2
printf("[RDV] Use Realsense2 Camea\n") ;

CRealsense *cap = NULL;

try
{
cap = new CRealsense() ;
}
#else
printf("[RDV] Use Opencv Video Capture\n") ;

cv::VideoCapture* cap = NULL;
try
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juhong-rdv Hi,

Is there any advantage to using cap = new CRealsense() ; over cap = new cv::VideoCapture(index); for Intel-Realsense RGB?

Is it better to integrate Intel-Realsense RGBD to the https://github.com/AlexeyAB/darknet/blob/master/src/yolo_console_dll.cpp as it is done for ZED-Camera, so it can show Distance to the objects too?

src/demo.c Outdated
Comment on lines 294 to 300
draw_detections_cv_v3(show_img, local_dets, local_nboxes, demo_thresh, demo_names, demo_alphabet, demo_classes, demo_ext_output);

#ifdef REALSENSE2

draw_detections_cv_v3(show_img, local_dets, local_nboxes, demo_thresh, demo_names, demo_alphabet, demo_classes, demo_ext_output);
#endif
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems draw_detections_cv_v3 is called twice.

@cenit
Copy link
Collaborator

cenit commented Aug 10, 2020

is it possible for you to update also the CMake toolchain?
Please also consider that realsense2 is also available on vcpkg (it's their preferred installation method) so maybe a couple of notes on that too might be very useful. I can also add a darknet feature on vcpkg after this PR to enable this functionality very easily :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants