Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old session loading #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Old session loading #104

wants to merge 2 commits into from

Conversation

sbergen
Copy link
Contributor

@sbergen sbergen commented Jan 5, 2015

Fixed some issues I found with loading an old session file.

The file had <Session version="0.908.2" ... > in it and it was recorded with some version of A2 IIRC. Not sure if the code is 100% correct even like this...

While at it, I added a utility class for finding Statefuls by id with standard algorithms, as the code is much more readable like this IMO.

@mojofunk
Copy link
Contributor

mojofunk commented Jan 6, 2015

I'm not sure what the policy is on supporting loading of older sessions especially very old sessions that may cause other issues with current versions. If this is accepted it would be nice if we could add the session file to the libardour tests.

The refactoring looks OK but I'm not sure that you are using the correct visibility/export macro though, I don't think you need any for non-template header only classes. I think I'd also prefer that class was defined in the pbd/stateful.h header.

@x42
Copy link
Member

x42 commented Sep 23, 2023

Do you still have this ancient session?

In general Ardour should be able to load and convert old sessions, but v0.x.x sessions are likely not reasonable to support. Still detecting the old session format would still be useful.

@luzpaz
Copy link
Contributor

luzpaz commented Sep 23, 2023

ping @sbergen

@sbergen
Copy link
Contributor Author

sbergen commented Sep 24, 2023

I found some old sessions in my archives with a matching session version, but I can't be sure if one of them is this specific one. @x42 are the xml session files enough for what you'd like to do, or do you need something else also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants