Skip to content

Commit

Permalink
remove module-info, The Spring Framework 5.x does not support module-…
Browse files Browse the repository at this point in the history
…info (#27254)

* remove module-info, The Spring Framework 5.x does not support module-info.java in their libraries. We want to align this in our Spring implementations.

spring-projects/spring-framework#18079

* remove surefire plugin java modules proeprties from pom.xml

Co-authored-by: Xiaolu Dai <[email protected]>
  • Loading branch information
stliu and saragluna authored Feb 23, 2022
1 parent 1208566 commit 9b22bc5
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 127 deletions.
18 changes: 0 additions & 18 deletions sdk/spring/spring-cloud-azure-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,24 +32,6 @@
<url>https://github.com/Azure/azure-sdk-for-java/issues</url>
</issueManagement>


<properties>
<!-- Configures the Java 9+ run to perform the required module exports, opens, and reads that are necessary for testing but shouldn't be part of the module-info. -->
<!-- https://issues.apache.org/jira/browse/SUREFIRE-1563 -->
<javaModulesSurefireArgLine>
--add-modules com.azure.storage.blob
--add-modules com.azure.storage.file.share
--add-modules com.azure.storage.internal.avro
--add-opens com.azure.spring.core/com.azure.spring.core.credential=ALL-UNNAMED
--add-opens com.azure.spring.core/com.azure.spring.core.factory=ALL-UNNAMED
--add-opens com.azure.spring.core/com.azure.spring.core.implementation.connectionstring=ALL-UNNAMED
--add-opens com.azure.spring.core/com.azure.spring.core.implementation.credential.resolver=ALL-UNNAMED
--add-opens com.azure.spring.core/com.azure.spring.core.resource=ALL-UNNAMED
--add-opens com.azure.spring.core/com.azure.spring.core.util=ALL-UNNAMED
--add-opens com.azure.spring.core/com.azure.spring.core=ALL-UNNAMED
</javaModulesSurefireArgLine>
</properties>

<dependencies>
<dependency>
<groupId>org.springframework</groupId>
Expand Down
37 changes: 0 additions & 37 deletions sdk/spring/spring-cloud-azure-core/src/main/java/module-info.java

This file was deleted.

8 changes: 0 additions & 8 deletions sdk/spring/spring-cloud-azure-resourcemanager/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,6 @@
<url>https://github.com/Azure/azure-sdk-for-java/issues</url>
</issueManagement>

<properties>
<javaModulesSurefireArgLine>
--add-opens com.azure.spring.resourcemanager/com.azure.spring.resourcemanager.connectionstring=ALL-UNNAMED
--add-opens com.azure.spring.resourcemanager/com.azure.spring.resourcemanager.provisioning.servicebus=ALL-UNNAMED
--add-opens com.azure.spring.resourcemanager/com.azure.spring.resourcemanager.provisioning.eventhubs=ALL-UNNAMED
--add-opens com.azure.spring.resourcemanager/com.azure.spring.resourcemanager.implementation.crud=ALL-UNNAMED
</javaModulesSurefireArgLine>
</properties>
<dependencies>
<dependency>
<groupId>com.azure.spring</groupId>
Expand Down

This file was deleted.

32 changes: 0 additions & 32 deletions sdk/spring/spring-cloud-azure-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,38 +33,6 @@
<url>https://github.com/Azure/azure-sdk-for-java/issues</url>
</issueManagement>

<properties>
<javaModulesSurefireArgLine>
--add-modules com.azure.cosmos
--add-modules com.azure.data.appconfiguration
--add-modules com.azure.messaging.eventhubs
--add-modules com.azure.messaging.servicebus
--add-modules com.azure.security.keyvault.certificates
--add-modules com.azure.security.keyvault.secrets
--add-modules com.azure.storage.blob
--add-modules com.azure.storage.file.share
--add-modules com.azure.storage.internal.avro
--add-modules com.azure.storage.queue
--add-opens com.azure.spring.core/com.azure.spring.core.factory=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.eventhubs=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.appconfiguration=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.core=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.cosmos=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.credential=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.converter=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.eventhubs=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.keyvault.certificates=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.keyvault.secret=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.servicebus.factory=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.servicebus=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.storage.credential=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.storage.blob=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.storage.fileshare=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.storage.queue=ALL-UNNAMED
--add-opens com.azure.spring.service/com.azure.spring.service.implementation=ALL-UNNAMED
</javaModulesSurefireArgLine>
</properties>

<dependencies>
<dependency>
<groupId>com.azure.spring</groupId>
Expand Down

This file was deleted.

0 comments on commit 9b22bc5

Please sign in to comment.