Tokenizer improvements #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 95.98% 95.92% -0.06%
==========================================
Files 16 16
Lines 1793 1793
==========================================
- Hits 1721 1720 -1
- Misses 72 73 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Issue 125 revealed several issues with the existing tokenizer implementation, several of which are fixed here: * `tokenize` now correctly uses the `version` argument * Documentation is now clearer, and several tokenizer functions are doctested * Several tokenizer tests were forgotten - these are now included and updated to work.
jakobnissen
force-pushed
the
tokenize
branch
from
7568d56
to
989800b
Compare
Closed
|
nice thanks!! could this be made into a patch release? 🙏 |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes and doc improvements to Tokenizer
Issue 125 revealed several issues with the existing tokenizer implementation,
several of which are fixed here:
tokenizenow correctly uses theversionargumentto work.