Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TranscodingStreams to 0.11 #135

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Bump TranscodingStreams to 0.11 #135

merged 3 commits into from
Jul 3, 2024

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Jul 3, 2024

TranscodingStreams release notes: https://github.com/JuliaIO/TranscodingStreams.jl/releases/tag/v0.11.0

The seekend and Memory changes do not affect this package.

The changes to eof may mean that Automa.jl may error differently when accidentally trying to read a closed stream, but I don't think this changes the API of Automa.jl.

@nhz2
Copy link
Contributor Author

nhz2 commented Jul 3, 2024

Seems like setup-julia is trying to install an ARM64 version of julia 1.6. Maybe updating setup-julia will fix it?

@jakobnissen
Copy link
Member

It's because the unit tests YAML file specifies running Julia 1.6 on macos-latest, but the latest versions of MacOS only run on arm.
See https://github.com/BioJulia/FASTX.jl/blob/master/.github/workflows/UnitTesting.yml.

Maybe for Automa we also want to test 1.6 on an older version of MacOs on x86, but I don't know how to specify that

This is because the latest MacOS doesn't work with x86, and Julia LTS doesn't
work with MacOS AArch64.
So instead, we test with 1.9 for MacOS.
@jakobnissen jakobnissen merged commit ee6f41b into BioJulia:master Jul 3, 2024
17 checks passed
@jakobnissen
Copy link
Member

Thanks for the contribution, @nhz2 !

@nhz2 nhz2 deleted the ts_bump branch July 3, 2024 19:35
@kescobo kescobo mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants