Migrate to Automa v1 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is not entirely straightforward. One of the major changes in Automa v1 is the detection of ambiguos NFAs at compile time. Automa's behaviour in the presence of such NFAs is undefined. It turns out that the existing BED Machines were ambiguous, which means there probably was some latent bugs waiting to happen. To mitigate these, the Machine's behaviour has been slightly changed. In particular: * Chrom now cannot start with # or with whitespace, to distinguish them from comments and whitespace * Blank lines now no longer can start with tabs, to distinguish them from a record with an empty chrom name I'm guessing this will not cause any issues in practise.
This has been LTS for years. Also update CI
11 tasks
|
Thank you! Is there a scheduled upcoming release or should I just use develop? |
|
Oh right, forgot that. I will make a release later tonight - use develop for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is not entirely straightforward. One of the major changes in Automa v1 is the detection of ambiguos NFAs at compile time. Automa's behaviour in the presence of such NFAs is undefined.
It turns out that the existing BED Machines were ambiguous, which means there probably was some latent bugs waiting to happen.
To mitigate these, the Machine's behaviour has been slightly changed. In particular:
I'm guessing this will not cause any issues in practise.
Supersedes #18, cc. @kescobo