Fix high rated bugs reported by pio check

Blueforcer · Oct 19, 2023 · b392e9e · b392e9e
1 parent 77c113c
commit b392e9e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/DisplayManager.cpp b/src/DisplayManager.cpp
@@ -770,6 +770,8 @@ bool DisplayManager_::generateNotification(uint8_t source, const char *json)
   newNotification.repeat = doc.containsKey("repeat") ? doc["repeat"].as<int>() : -1;
   newNotification.fade = doc.containsKey("fadeText") ? doc["fadeText"].as<int>() : 0;
   newNotification.blink = doc.containsKey("blinkText") ? doc["blinkText"].as<int>() : 0;
+  newNotification.barSize = 0;
+  newNotification.lineSize = 0;
   if (newNotification.noScrolling)
   {
     newNotification.repeat = -1;

diff --git a/src/Functions.cpp b/src/Functions.cpp
@@ -85,7 +85,7 @@ uint32_t getColorFromJsonVariant(JsonVariant colorVariant, uint32_t defaultColor
             uint8_t s = colorArray[2];
             uint8_t v = colorArray[3];
             // Assuming you have a function to convert HSV to RGB
-            uint8_t r, g, b;
+            uint8_t r = 0, g = 0, b = 0;
             // hsv2rgb(h, s, v, r, g, b);
             return (r << 16) | (g << 8) | b; // Ignoring alpha channel
         }

diff --git a/src/MQTTManager.cpp b/src/MQTTManager.cpp
@@ -503,8 +503,8 @@ void MQTTManager_::setup()
         mqtt.setDataPrefix(MQTT_PREFIX.c_str());
         uint8_t mac[6];
         WiFi.macAddress(mac);
-        char *macStr = new char[18 + 1];
-        snprintf(macStr, 24, "%02x%02x%02x", mac[3], mac[4], mac[5]);
+        char macStr[7];
+        snprintf(macStr, 7, "%02x%02x%02x", mac[3], mac[4], mac[5]);
         device.setUniqueId(mac, sizeof(mac));
         device.setName(uniqueID);
         device.setSoftwareVersion(VERSION);