BCDA-8230: Remove hashed MBI #982
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyeah
commented
Aug 6, 2024
| @@ -1,125 +1,98 @@ | |||
| $ANSIBLE_VAULT;1.1;AES256 | |||
There was a problem hiding this comment.
Removed BB_HASH_ITER and BB_HASH_PEPPER
| @@ -66,7 +64,7 @@ type APIClient interface { | |||
| GetExplanationOfBenefit(jobData models.JobEnqueueArgs, patientID string, claimsWindow ClaimsWindow) (*fhirModels.Bundle, error) | |||
| GetPatient(jobData models.JobEnqueueArgs, patientID string) (*fhirModels.Bundle, error) | |||
| GetCoverage(jobData models.JobEnqueueArgs, beneficiaryID string) (*fhirModels.Bundle, error) | |||
| GetPatientByIdentifierHash(jobData models.JobEnqueueArgs, hashedIdentifier string) (string, error) | |||
| GetPatientByMbi(jobData models.JobEnqueueArgs, mbi string) (string, error) | |||
There was a problem hiding this comment.
Any argument to keep GetPatientByIdentifierHash functionality? Or is this a known permanent change?
| params.Set("excludeSAMHSA", "true") | ||
|
|
||
| updateParamWithServiceDate(¶ms, claimsWindow) | ||
| updateParamWithLastUpdated(¶ms, jobData.Since, jobData.TransactionTime) | ||
|
|
||
| u, err := bbc.getURL("Claim", params) | ||
| u, err := bbc.getURL("Claim/_search", params) |
There was a problem hiding this comment.
We use getURL above as well. Some nitpicks/thoughts:
- We should return the same thing each time (we return empty string above and nil here)
- Do we want to return anything more useful than an empty string? Looking at getURL it is already catching an error, maybe getURL doesnt need to return an error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8230
🛠 Changes
ℹ️ Context
🧪 Validation