Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QPPSE-317: Refactor decocer/encoder static variables #1463

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

sivaksb
Copy link
Contributor

@sivaksb sivaksb commented Oct 3, 2024

Information

  • Refactored decoder and encoder constant static variables to a common file

Checklist

  • All JUnit tests pass (mvn clean verify).
  • New unit tests written to cover new functionality.
  • Added and updated JavaDocs for non-test classes and methods.
  • No local design debt. Do you feel that something is "ugly" after your changes?
  • Updated documentation (README.md, etc.) depending if the changes require it.

@sivaksb sivaksb requested a review from Jpec07 as a code owner October 3, 2024 22:09
Copy link

sonarcloud bot commented Oct 3, 2024

@cabedi-icf
Copy link

pretty much puts the static variables into a model package, looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants