#7 Colors #23
Open
#7 Colors #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include jest and rWV
.env files should never be committed, but it's ok to have an example file with fake values to cue developers to update their env
no values in here yet, just examples
added code tags for syntax highlighting removed git add . advice as it causes chaos
and remove display/copy differentiation
✅ Deploy Preview for rainyplaytime ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SallyMcGrath
previously requested changes
Feb 4, 2023
There was a problem hiding this comment.
Thanks for this. I think that it would be helpful if we described the function of the colours in the design instead of reiterating the value.
There are some suggestions in the linked ticket. Take a look. I think we could very easily make a dark mode if we choose this approach.
LucyMac
approved these changes
Feb 25, 2023
LucyMac
dismissed
SallyMcGrath’s stale review
Dismissing in Sally's absence just to get this merged in so we can make progress as a team :)
LucyMac
reviewed
Feb 25, 2023
Comment on lines
+10
to
+11
| background-color: var(--theme-color-blue-light); | ||
| color: var(--theme-color-blue-navy); |
There was a problem hiding this comment.
@youweb3 these colours no long exist since you have changed the naming of your colour variables. Please update these before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributors, PR Template
Self checklist
Changelist
Briefly explain your PR.
Context
Link to ticket with
fixes #123Questions
Ask any questions you have for your reviewer.