Future weather #10 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include jest and rWV
.env files should never be committed, but it's ok to have an example file with fake values to cue developers to update their env
no values in here yet, just examples
added code tags for syntax highlighting removed git add . advice as it causes chaos
and remove display/copy differentiation
set css variables to be available everywhere six levels the most common level will be --theme-spacing---3
#14 add JSON file with sample data
#5 spacing sizes
✅ Deploy Preview for rainyplaytime ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
fixes #10 |
delete Emeka's YL I will recreate it on main
we had to remove it from a branch and then merge the branch for expedience
25 re-add yarn lock
LucyMac
requested changes
Mar 2, 2023
There was a problem hiding this comment.
@Lunamzelo I have updated a few things on the main branch, so please could you update your branch future-weather with main? This means:
- Go to
mainand pull any changes - Go back to your
future-weatherbranch and mergemaininto your branch - Then push
This should update this PR and show fewer changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributors, PR Template
Self checklist
Changelist
Briefly explain your PR.
Context
The numbers array is not the actual data, it's just representing how it would be done.
Link to ticket with
fixes #123Questions
Ask any questions you have for your reviewer.