-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented decoding and hash rules for execution requests #8668
base: master
Are you sure you want to change the base?
Implemented decoding and hash rules for execution requests #8668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a question
.../pegasys/teku/spec/datastructures/execution/versions/electra/ExecutionRequestsDataCodec.java
Show resolved
Hide resolved
/* | ||
https://eips.ethereum.org/EIPS/eip-7251 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do need this comment at all, maybe single line?
switch (type) { | ||
case DepositRequest.REQUEST_TYPE: | ||
// https://eips.ethereum.org/EIPS/eip-6110 | ||
executionRequestsBuilder.deposits( | ||
executionRequestsSchema | ||
.getDepositRequestsSchema() | ||
.sszDeserialize(data.slice(1)) | ||
.asList()); | ||
break; | ||
case WithdrawalRequest.REQUEST_TYPE: | ||
// https://eips.ethereum.org/EIPS/eip-7002 | ||
executionRequestsBuilder.withdrawals( | ||
executionRequestsSchema | ||
.getWithdrawalRequestsSchema() | ||
.sszDeserialize(data.slice(1)) | ||
.asList()); | ||
break; | ||
case ConsolidationRequest.REQUEST_TYPE: | ||
// https://eips.ethereum.org/EIPS/eip-7251 | ||
executionRequestsBuilder.consolidations( | ||
executionRequestsSchema | ||
.getConsolidationRequestsSchema() | ||
.sszDeserialize(data.slice(1)) | ||
.asList()); | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new syntax for case statements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
PR Description
Implementing the rules for decoding and hashing execution requests according to ethereum/execution-apis#591
Fixed Issue(s)
part of #8620
Documentation
doc-change-required
label to this PR if updates are required.Changelog