Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rpc method return type checks in unit tests #8677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add rpc method return type checks in unit tests #8677

wants to merge 1 commit into from

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Oct 4, 2024 •
edited
Loading

PR Description

Add execution engine method return types checks.
This ensures that the return type is the expected one and not only that response future completes.

Fixed Issue(s)

fixes #8672

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi marked this pull request as ready for review October 4, 2024 14:57
@mehdi-aouadi mehdi-aouadi self-assigned this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mehdi-aouadi mehdi-aouadi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce EL RPC method types in the RPC method resolver
1 participant
@mehdi-aouadi