generated from DFE-Digital/govuk-rails-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow registration when service is closed #1146
Open
slawosz
wants to merge
1
commit into
main
Choose a base branch
from
1673-closed-registration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawosz
requested review from
Lockyy,
leoapost,
peteryates,
javier-npq and
pmanrubia
as code owners
February 15, 2024 12:43
slawosz
force-pushed
the
1673-closed-registration
branch
from
February 15, 2024 16:43
d345706
to
e3c8e2a
Compare
Review app deployed to https://npq-registration-review-1146-web.test.teacherservices.cloud/ |
slawosz
force-pushed
the
1673-closed-registration
branch
from
February 15, 2024 17:48
e3c8e2a
to
cf47bb8
Compare
slawosz
force-pushed
the
1673-closed-registration
branch
from
February 15, 2024 18:04
cf47bb8
to
ab02e77
Compare
slawosz
force-pushed
the
1673-closed-registration
branch
from
February 15, 2024 18:20
ab02e77
to
8df49cd
Compare
slawosz
force-pushed
the
1673-closed-registration
branch
from
February 16, 2024 12:29
8df49cd
to
a602cef
Compare
slawosz
force-pushed
the
1673-closed-registration
branch
from
February 27, 2024 13:58
a602cef
to
24f377d
Compare
slawosz
force-pushed
the
1673-closed-registration
branch
from
March 25, 2024 11:29
24f377d
to
8044480
Compare
slawosz
force-pushed
the
1673-closed-registration
branch
from
March 25, 2024 11:33
8044480
to
545364a
Compare
slawosz
force-pushed
the
1673-closed-registration
branch
from
March 25, 2024 14:10
d6ea66a
to
3cdf713
Compare
slawosz
changed the title
[SPIKE] allow registration when service is closed
Allow registration when service is closed
Mar 25, 2024
javier-npq
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work changes the registration open/close feature flag to enable it for certain users.
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-1673