[CPDLP-3510] npq internal api revisit fallback for funding eligibility logic in npq #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooktakim
force-pushed
the
3510-npq-internal-api-revisit-fallback-for-funding-eligibility-logic-in-npq
branch
from
228d473
to
48eccdb
Compare
|
Review app deployed to https://npq-registration-review-1741-web.test.teacherservices.cloud/ |
cwrw
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Thanks @mooktakim is it ok if we only focus on swapping out the feature flag on the funding eligibility section? as there is another ticket to tackle those which will change their location?
|
|
||
| it "returns nil" do | ||
| it ".call returns nil" do |
There was a problem hiding this comment.
it "returns nil" do ... ?
There was a problem hiding this comment.
those changes reverted now
There was a problem hiding this comment.
it was because call was tested but tsf_data_field_update wasn't.
|
leandroalemao
approved these changes
Sep 26, 2024
cwrw
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://dfedigital.atlassian.net.mcas.ms/browse/CPDLP-3510
Changes proposed in this pull request
Rails.application.config.npq_separation[:ecf_api_disabled]flags to useFeature.ecf_api_disabled?Ecf::NpqProfileUpdaterspec to include one more test