[CPDLP-3608] Fix bug with duplicate records in NPQ #1777
+20
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://npq-registration-review-1777-web.test.teacherservices.cloud/ |
|
| @@ -60,11 +60,12 @@ def where_from_participant_id_is(from_participant_id) | |||
| end | |||
|
|
|||
| def order_by | |||
| sort_order(sort:, model: User, default: { accepted_at: :asc }) | |||
| sort_order(sort:, model: User, default: { created_at: :asc }) | |||
There was a problem hiding this comment.
On the sorting order.. this change rolls back the one made here? https://dfedigital.atlassian.net/browse/CPDLP-3349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://dfedigital.atlassian.net.mcas.ms/browse/CPDLP-3608
Changes proposed in this pull request
Participants::Querynow by default sorts bycreated_atapplications.accepted_atto sorting forces query to return multipleUserrecords as it has to joinApplicationdistinctto the query