[CPDNPQ-2076] Admin Management #1781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://npq-registration-review-1781-web.test.teacherservices.cloud/ |
rwrrll
force-pushed
the
2076-admin-permissions
branch
from
7e43437
to
f79c8b4
Compare
rwrrll
force-pushed
the
2076-admin-permissions
branch
from
f79c8b4
to
89a4c18
Compare
|
peteryates
reviewed
Oct 4, 2024
| @@ -244,7 +244,7 @@ | |||
| end | |||
|
|
|||
| resources :lead_providers, only: %i[index show], path: "lead-providers" | |||
| resources :admins, only: %i[index] | |||
| resources :admins, except: :edit | |||
There was a problem hiding this comment.
I think referring to 'admins' inside the admin section could possibly be a bit confusing. As these people will be DfE staff, maybe /admin/staff?
Suggested change
| resources :admins, except: :edit | |
| resources :admins, except: :edit, path: "staff" |
|
Looking good so far. I left a suggestion on the naming as having an 'admins' section inside the admin section feels like it could be a bit confusing. Perhaps referring to DfE people as 'staff' would make things easier? (there's a fair chance that could just make everything more confusing - worth having a chat with the team). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-2076
Implement admin management currently at
/admin/adminsas new version at/npq-separation/admin/admins