[CPDNPQ-2128] Keep the user TRN unchanged when TRA returns an empty TRN #1782
+99
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going forward, we need to ensure that we only update the TRN in NPQ app if there is a change in the TRN recorded by DfE Identity. We never want the TRN field to be nil.
|
Review app deployed to https://npq-registration-review-1782-web.test.teacherservices.cloud/ |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-000
Our code is currently overriding the user's data with their TRA record. When a user's TRN doesn't match a TRA record, we allow them to submit their application with the TRN they provided. However, this leads to the TRN being overwritten with a blank value.
We need to ensure the TRN is retained in such cases.
Changes proposed in this pull request
Modify the User methods
find_or_create_from_tra_data_on_unclaimed_emailandfind_or_create_from_tra_data_on_uidto update the TRN only when a TRN is returned by TRA.