Fix broken update on changing the input box page value in ExtJS pagination #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table would not update if you changed the page value in the input box, i.e. if the input box showed page 1 and you changed it to page 5, nothing would happen whereas you would expect page 5 to be loaded into your table. `fnExtStylePagingInfo` is used in 3 other places in this file, so I guessed that the usage of `fnPagingInfo` in the `nPageNumBox.change` block was a typo and should have been `fnExtStylePagingInfo`. This indeed fixes the problem.
siccovansas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ExtJS pagination plugin, the table would not update if you changed the page value in the input box, i.e. if the input box showed page 1 and you changed it to page 5, nothing would happen whereas you would expect page 5 to be loaded into your table.
fnExtStylePagingInfois used in 3 other places in this file, so I guessed that the usage offnPagingInfoin thenPageNumBox.changeblock was a typo and should have beenfnExtStylePagingInfo. This indeed fixes the problem.