Fix trade signs not updating signs (Fixes #5814)

i guess these things are transactional now whatever
EssentialsX · Jul 21, 2024 · 80c3150 · 80c3150
1 parent 33e086f
commit 80c3150
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/Essentials/src/main/java/com/earth2me/essentials/signs/EssentialsSign.java b/Essentials/src/main/java/com/earth2me/essentials/signs/EssentialsSign.java
@@ -550,9 +550,11 @@ public void updateSign() {
 
     static class BlockSign implements ISign {
         private final transient Block block;
+        private transient Sign sign;
 
         BlockSign(final Block block) {
             this.block = block;
+            this.sign = getSign();
         }
 
         @Override
@@ -569,7 +571,7 @@ public final String getLine(final int index) {
 
         @Override
         public final void setLine(final int index, final String text) {
-            getSign().setLine(index, text);
+            sign.setLine(index, text);
             updateSign();
         }
 
@@ -586,7 +588,8 @@ private Sign getSign() {
 
         @Override
         public final void updateSign() {
-            getSign().update();
+            sign.update();
+            sign = getSign();
         }
     }
 }