Merge pull request #6 from EventSaucePHP/feature/allow-infinite-tries…

…-on-any-strategy Fixes #5: allow infinite retries on any implementation.
EventSaucePHP · Sep 17, 2023 · b7429a9 · b7429a9
2 parents 1fe47e1 + 623d555
commit b7429a9
Show file tree

Hide file tree

Showing 6 changed files with 47 additions and 3 deletions.
diff --git a/src/ExponentialBackOffStrategy.php b/src/ExponentialBackOffStrategy.php
@@ -45,7 +45,7 @@ public function __construct(
      */
     public function backOff(int $tries, Throwable $throwable): void
     {
-        if ($tries > $this->maxTries) {
+        if ($this->maxTries !== -1 && $tries > $this->maxTries) {
             throw $throwable;
         }
 

diff --git a/src/ExponentialBackOffStrategyTest.php b/src/ExponentialBackOffStrategyTest.php
@@ -7,6 +7,7 @@
 use LogicException;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
+use const PHP_INT_MAX;
 
 class ExponentialBackOffStrategyTest extends TestCase
 {
@@ -134,4 +135,17 @@ public function dpExpectedSleepFromExponent(): iterable
             [3, 2.5, 625],
         ];
     }
+
+    /**
+     * @test
+     */
+    public function it_does_not_throw_an_exception_when_max_tries_is_infinite(): void
+    {
+        $this->expectNotToPerformAssertions();
+
+        $backoff = new ExponentialBackOffStrategy(0, -1);
+        $exception = new RuntimeException('oops');
+
+        $backoff->backOff(PHP_INT_MAX, $exception);
+    }
 }
diff --git a/src/FibonacciBackOffStrategy.php b/src/FibonacciBackOffStrategy.php
@@ -38,7 +38,7 @@ public function __construct(
 
     public function backOff(int $tries, Throwable $throwable): void
     {
-        if ($tries > $this->maxTries) {
+        if ($this->maxTries !== -1 && $tries > $this->maxTries) {
             throw $throwable;
         }
 

diff --git a/src/FibonacciBackOffStrategyTest.php b/src/FibonacciBackOffStrategyTest.php
@@ -7,6 +7,7 @@
 use LogicException;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
+use const PHP_INT_MAX;
 
 class FibonacciBackOffStrategyTest extends TestCase
 {
@@ -61,4 +62,17 @@ public function it_throws_when_over_max_tries(): void
 
         $backOff->backOff(26, $exception);
     }
+
+    /**
+     * @test
+     */
+    public function it_does_not_throw_an_exception_when_max_tries_is_infinite(): void
+    {
+        $this->expectNotToPerformAssertions();
+
+        $backoff = new FibonacciBackOffStrategy(0, -1);
+        $exception = new RuntimeException('oops');
+
+        $backoff->backOff(PHP_INT_MAX, $exception);
+    }
 }
diff --git a/src/LinearBackOffStrategy.php b/src/LinearBackOffStrategy.php
@@ -40,7 +40,7 @@ public function __construct(
      */
     public function backOff(int $tries, Throwable $throwable): void
     {
-        if ($tries > $this->maxTries) {
+        if ($this->maxTries !== -1 && $tries > $this->maxTries) {
             throw $throwable;
         }
 

diff --git a/src/LinearBackOffStrategyTest.php b/src/LinearBackOffStrategyTest.php
@@ -6,6 +6,7 @@
 use EventSauce\BackOff\Jitter\NoJitter;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
+use const PHP_INT_MAX;
 
 class LinearBackOffStrategyTest extends TestCase
 {
@@ -97,6 +98,21 @@ public function dpGoingOverTheMaxTries(): iterable
         ];
     }
 
+
+
+    /**
+     * @test
+     */
+    public function it_does_not_throw_an_exception_when_max_tries_is_infinite(): void
+    {
+        $this->expectNotToPerformAssertions();
+
+        $backoff = new LinearBackOffStrategy(0, -1);
+        $exception = new RuntimeException('oops');
+
+        $backoff->backOff(PHP_INT_MAX, $exception);
+    }
+
     /**
      * @test
      */