feat(jobs): Add job to migrate analytics data from influx to postgres #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagantrivedi
force-pushed
the
feat/jobs-migrate-analytics
branch
from
d2f2542
to
39d1686
Compare
khvn26
requested changes
Jun 21, 2024
Comment on lines
16
to
24
| spec: | ||
| restartPolicy: Never | ||
| containers: |
There was a problem hiding this comment.
Let's add:
extraContainersextraVolumesshareProcessNamespaceserviceAccountName
to support all kinds of database connectivity configurations
See jobs-migrate-db for an example
| @@ -52,6 +52,15 @@ | |||
| name: {{ template "flagsmith.influxdb.fullname" . }}-external-auth | |||
| key: admin-token | |||
| {{- end }} | |||
| {{- else if .Values.UsePostgresForAnalytics.enabled }} | |||
| {{- if not .Values.taskProcessor.enabled }} | |||
| {{ fail "To use Postgre for analytics, the task processor must be enabled" }} | |||
There was a problem hiding this comment.
Suggested change
| {{ fail "To use Postgre for analytics, the task processor must be enabled" }} | |
| {{ fail "To use PostgreSQL for analytics, `taskProcessor.enabled` should be set to `true`" }} |
charts/flagsmith/templates/NOTES.txt
Outdated
| ###################################### | ||
|
|
||
| InfluxDB2 is deprecated and will be removed in the next major version. | ||
| You can either use InfluxDBExternal or migrate your analytics data to PostgreSQL by using the migrateAnalyticsData job |
There was a problem hiding this comment.
Suggested change
| You can either use InfluxDBExternal or migrate your analytics data to PostgreSQL by using the migrateAnalyticsData job | |
| Please set values under the `influxdbExternal` key | |
| or migrate your analytics data to PostgreSQL by enabling `jobs.migrateAnalytics`. |
gagantrivedi
force-pushed
the
feat/jobs-migrate-analytics
branch
2 times, most recently
from
37693b6
to
1f8d1f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
/charts/flagsmith/Chart.yamlin the sectionversionor I'm merging to arelease branch
Changes
Please describe.
How did you test this code?
Please describe.