Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attestationreport: implemented Intel SGX and TDX quote verification #160

Merged
merged 1 commit into from
Jan 29, 2024
Merged

attestationreport: implemented Intel SGX and TDX quote verification #160

merged 1 commit into from
Jan 29, 2024

Conversation

cdotsh
Copy link
Contributor

@cdotsh cdotsh commented Dec 11, 2023

Changes:

  • intel_helpers.go:
    • common structs and parsing functions for SGX/TDX Collateral, Certificates, ...
    • helper functions for quote and collateral verification, fetching CRLs, ...
  • sgx.go (SGX Quote Verification)
  • sgx_test.go (Tests for the SGX verification function)
  • tdx.go (TDX Quote Verification)
  • tdx_test.go (Tests for the TDX verification function)
  • attestationreport_test.go (added tests for the generic report Verify() function with TDX)
  • attestationreport.go (added SGX/TDX specific structs)
  • verificationreport.go (added SGX/TDX specific structs)

@cdotsh cdotsh changed the title attestationreport: integrated Intel SGX and TDX verifier attestationreport: implemented Intel SGX and TDX quote verification Dec 11, 2023
smo4201
smo4201 requested changes Jan 9, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
attestationreport/attestationreport.go Outdated Show resolved Hide resolved
attestationreport/attestationreport.go Show resolved Hide resolved
attestationreport/tdx_test.go Outdated Show resolved Hide resolved
mokamhuber
mokamhuber requested changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@mokamhuber mokamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht grundsätzlich schon sehr gut aus. Ein paar Kleinigkeiten hab ich noch angemerkt :)

attestationreport/attestationreport.go Outdated Show resolved Hide resolved
attestationreport/attestationreport.go Show resolved Hide resolved
attestationreport/attestationreport_test.go Outdated Show resolved Hide resolved
attestationreport/attestationreport_test.go Show resolved Hide resolved
attestationreport/attestationreport_test.go Show resolved Hide resolved
attestationreport/sgx_test.go Outdated Show resolved Hide resolved
attestationreport/tdx.go Outdated Show resolved Hide resolved
attestationreport/tdx.go Outdated Show resolved Hide resolved
attestationreport/tdx_test.go Show resolved Hide resolved
attestationreport/validationreport.go Outdated Show resolved Hide resolved
@cdotsh cdotsh force-pushed the intel_integration branch 4 times, most recently from 2cdcc13 to a9e5ded Compare January 23, 2024 14:49
@mokamhuber mokamhuber merged commit d95311f into Fraunhofer-AISEC:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokamhuber mokamhuber mokamhuber approved these changes

@smo4201 smo4201 smo4201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdotsh @mokamhuber @smo4201