chore(testing): Add basic unit test for Services Scanner #496
Conversation
| @@ -80,10 +80,10 @@ def configure_parser(self) -> None: | |||
| async def main(self, args: Namespace) -> None: | |||
| self.result: list[tuple[int, int]] = [] | |||
| self.ecu.max_retry = 1 | |||
| found: dict[int, dict[int, Any]] = {} | |||
| self.found: dict[int, dict[int, Any]] = {} | |||
There was a problem hiding this comment.
A unified interface for scanner results needs to be defined; this is not decided yet. So for these first tests, let's use your solution. We could adjust this later.
|
|
||
|
|
||
| @dataclass | ||
| class Args: |
There was a problem hiding this comment.
For now ok; in gallia 2.0 this will be replaced by config containers.
| """ | ||
| assert self.scanner is not None | ||
|
|
||
| async def handle( |
There was a problem hiding this comment.
As discussed via phone: This will be replaced via a table with TypedDicts, as suggested by russ cox: https://research.swtch.com/testing. Especially his tips 1, 5, 8, and 11 are relevant here.
Your draft from #495 could be used for a starting point.
| assert self.scanner.found[1][0x27] == TimeoutError.__name__ | ||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_3(self, setup: None, teardown: None) -> None: |
There was a problem hiding this comment.
Find descriptive test case names
|
|
||
| @pytest.mark.asyncio | ||
| @pytest.fixture | ||
| @patch("gallia.transports.unix.UnixTransport.connect") |
There was a problem hiding this comment.
Let's create a separate vecu transport for testing.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is a first draft of a unit test on scanner level.
The code uses
pytestand the python inbuiltunittest.mocklibrary.Because of missing modularization, mocking the
argparselibrary is necessary,which will be fixed in the future via a config container.
Currently, the transport module is mocked, but we could also create an own transport module for testing purpose.
As we currently have no defined scanner result, changes in the
scan-servicesscanner are included for demonstration purposes.To handle most of the default requests, the vECU is used.
To define test case specific ECU behavior, a callback
hook_requestis provided, which can overwrite the response from the vECU.Three different ECU behaviors are implemented:
TimeoutErrorexception)In the draft, three basic test cases for the scan-services scanner are included:
You can run the test cases via pytest: