Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): Last Oasis #3525

Closed
wants to merge 0 commits into from

Conversation

Claiyc
Copy link
Member

@Claiyc Claiyc commented Aug 1, 2021

Note: 2nd pr has needed to be raised as code ended up in develop branch
#3565

Description

If applied, this will add a new server Last Oasis.

Fixes #2808

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@Claiyc
Copy link
Member Author

Claiyc commented Aug 1, 2021

About the missing configfile on installation: Afaik you can edit the Game.ini and add some configuration stuff there, although you normally do that via the webinterface that last oasis provides automatically. That's why I didn't provide a default config, as it would be emtpy anyways. An emtpy Game.ini will be generated on first server stop, so the "missing configfile" warning disappears then.

@h3o66 h3o66 linked an issue Aug 3, 2021 that may be closed by this pull request
4 tasks
Copy link
Member

@h3o66 h3o66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and would be needed for the next release

@dgibbs64
Copy link
Member

Keep crashing for me. Can you confirm that it is running OK?

@Claiyc
Copy link
Member Author

Claiyc commented Sep 22, 2021

@dgibbs64 Can‘t check rn as I am currently in greece (and will be for another week). I tested it on deb10 when I created this pr and everything worked smoothly on first attempt.

@dgibbs64
Copy link
Member

Having to do some git wizardry to remove the lo commits from develop.

@dgibbs64 dgibbs64 mentioned this pull request Sep 23, 2021
13 tasks
@dgibbs64
Copy link
Member

@Claiyc looks like I have to resgister the server for it to run I think. Which involves buying the game

@Claiyc
Copy link
Member Author

Claiyc commented Sep 23, 2021

@dgibbs64 yes, that is definitely the case. Makes sense that the server crashes for you then. I opened a pr in the lgsm docs github with some more explanation: GameServerManagers/LinuxGSM-Docs#77

@dgibbs64
Copy link
Member

Thanks looks like I will have to buy a copy to test this one out

@Claiyc
Copy link
Member Author

Claiyc commented Sep 23, 2021

@dgibbs64 Even if you don‘t want to play the game, it‘s definitely worth a look as it is some really exciting technology I‘ve never seen in any other game server before. Also take a look at the server request issue linked to this pr, I linked some official references there.

@dgibbs64
Copy link
Member

Thanks. I am going to drop a message on their discord to see if they would be willing to dift me a copy. Sometimes devs are willing 👍

@dgibbs64 dgibbs64 added this to the v21.3.0 milestone Sep 26, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server Request] Last Oasis
3 participants