Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mods): metamod gamemode fix #4500

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pcace
Copy link

@pcace pcace commented Feb 18, 2024

Description

Only applies if metamod addon is installed on a cs2 server:
currently the gamemode.gi gets overwritten when updating the cs2 installation, but metamod needs to be referenced in the gamemod.gi by:
Game csgo/addons/metamod

this fix adds the needed integration of metamod to the gamemod.gi file if it is not there and if metamod is installed.

Fixes #4492

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

currently the gamemode.gi gets overwritten when updating the cs2 installation, but metamod needs to be referenced in the gamemod.gi. this fix adds the fix to the file if it is not there and if metamod is installed.
@pcace pcace changed the title Feature/cs2 metamod gamemode fix fix(mods): metamod gamemode fix Feb 18, 2024
@dgibbs64
Copy link
Member

dgibbs64 commented Mar 8, 2024

I feel like this is an issue that should be dealt with by metamod rather LinuxGSM creating this type of fix. Are there any metamod discussions about this issue and any long term fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants